tejohnson added a comment.

In D72538#4291552 <https://reviews.llvm.org/D72538#4291552>, @nikic wrote:

> Would it be possible to cut down the Clang side tests to only check parts 
> that Clang controls in some way, e.g. that SLPVectorizer is enabled? This 
> test is something of a PITA because it tests LLVM implementation details but 
> is not part of the LLVM tests, so it usually gets missed when doing pipeline 
> changes.

I think we can cut this down significantly, since the llvm tests added here 
check the full ThinLTO default pipeline setup at different opt levels. However, 
the point of the clang test is to make sure that for a distributed ThinLTO 
backend we correctly invoke thinBackend() which should set up the ThinLTO 
default pipeline. So how about I cut this down to check a single pass that is 
only invoked in the LTO backends? Specifically, I'm thinking of 
WholeProgramDevirtPass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72538/new/

https://reviews.llvm.org/D72538

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to