This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5794ea421a0d: [Sema] Fix _Alignas/isCXX11Attribute() FIXME
(authored by rsandifo-arm).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149148/new/
https://reviews.llvm.org/D149148
Files:
clang/lib/Sema/SemaDeclAttr.cpp
Index: clang/lib/Sema/SemaDeclAttr.cpp
===================================================================
--- clang/lib/Sema/SemaDeclAttr.cpp
+++ clang/lib/Sema/SemaDeclAttr.cpp
@@ -8591,13 +8591,7 @@
// Ignore C++11 attributes on declarator chunks: they appertain to the type
// instead.
- // FIXME: We currently check the attribute syntax directly instead of using
- // isCXX11Attribute(), which currently erroneously classifies the C11
- // `_Alignas` attribute as a C++11 attribute. `_Alignas` can appear on the
- // `DeclSpec`, so we need to let it through here to make sure it is processed
- // appropriately. Once the behavior of isCXX11Attribute() is fixed, we can
- // go back to using that here.
- if (AL.getSyntax() == ParsedAttr::AS_CXX11 &&
!Options.IncludeCXX11Attributes)
+ if (AL.isCXX11Attribute() && !Options.IncludeCXX11Attributes)
return;
// Unknown attributes are automatically warned on. Target-specific attributes
Index: clang/lib/Sema/SemaDeclAttr.cpp
===================================================================
--- clang/lib/Sema/SemaDeclAttr.cpp
+++ clang/lib/Sema/SemaDeclAttr.cpp
@@ -8591,13 +8591,7 @@
// Ignore C++11 attributes on declarator chunks: they appertain to the type
// instead.
- // FIXME: We currently check the attribute syntax directly instead of using
- // isCXX11Attribute(), which currently erroneously classifies the C11
- // `_Alignas` attribute as a C++11 attribute. `_Alignas` can appear on the
- // `DeclSpec`, so we need to let it through here to make sure it is processed
- // appropriately. Once the behavior of isCXX11Attribute() is fixed, we can
- // go back to using that here.
- if (AL.getSyntax() == ParsedAttr::AS_CXX11 && !Options.IncludeCXX11Attributes)
+ if (AL.isCXX11Attribute() && !Options.IncludeCXX11Attributes)
return;
// Unknown attributes are automatically warned on. Target-specific attributes
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
