dankm added inline comments.
================ Comment at: clang/test/CodeGen/debug-prefix-map.cpp:1 +// RUN: %clang++ -g -fdebug-prefix-map=%p=./UNLIKELY_PATH/empty -S -c %s -emit-llvm -o - | FileCheck %s --check-prefix=CHECK-REL + ---------------- dankm wrote: > aaron.ballman wrote: > > I'm taking a guess at correcting the RUN line here, but more tweaks may be > > needed. Basically, `%clang++` isn't a thing, so this test fails. Most of > > our tests should be testing `%clang_cc1` to test the frontend invocation, > > but some of the debug prefix map tests use `%clang` to test the driver > > functionality. I don't think there's a need to test the driver here, so I > > went with `%clang_cc1`. I'm not 100% certain whether `-debug-info-kind=` is > > necessary or not, but the other tests seem to be using that, which may be > > worth paying attention to. > > > > Finally, there's no need to have a custom check prefix for `FileCheck`, the > > builtin `CHECK` prefix suffices. > Okay, noted about clang++, it did work for me locally, but that doesn't mean > it's correct. Good point about only testing the frontend action, the driver > test is unnecessary. > > The custom check prefix is just a cut & paste artefact from copying from the > C version of the debug-prefix-map test, originally I was going to update that > test to a C++ file but opted later for just creating a new test. Ah, I see now it failed on the windows build in my test. Neat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
