awarzynski added a comment. I've just reverted this patch - for context please see https://reviews.llvm.org/D149429.
@sunshaoce This was committed <https://reviews.llvm.org/rG876df74dd47196a9ca3b4fff21ffb5441491a0a0> without acknowledging @ekieri 's contribution, so didn't follow the official guidelines: Attribution of Changes <https://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes>. IMHO, we should keep Emil as the author of this change (he has done the lion share of this highly non-trivial work) and add you as a co-author <https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-github>. Unless @ekieri has some other preference :) (I am happy as long as we follow the guidelines). Either way, thank you **both** for contributing! Now, lets try to figure out what caused the issue with the bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
