[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

[Yurong via Phabricator via cfe-commits]

yronglin added reviewers: rsmith, rjmccall.
yronglin added a comment.

Looks good from my side



================
Comment at: clang/lib/Sema/SemaChecking.cpp:7987
+      return true;
     TheCall->setArg(0, FirstArgResult.get());
   }
----------------
Can we add a comments here that we ignored the in-place updating for 1st arg 
from checkBuiltinArgument?


================
Comment at: clang/test/Sema/builtin-assume-aligned.c:79
+
+int test15(int *b) {
+  int arr[3] = {1, 2, 3};
----------------
Please add a test for function type


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149514/new/

https://reviews.llvm.org/D149514

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits