vitalybuka accepted this revision. vitalybuka added 2 blocking reviewer(s): eugenis, MaskRay. vitalybuka added a comment.
In D143675#4310734 <https://reviews.llvm.org/D143675#4310734>, @rsundahl wrote: > @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality > is under the added flag so not expecting any surprises. Rename > asabi->asan_abi as suggested. Thanks, asan_abi LGTM. I don't have good reasons to object that patch, but I suspect it's sub-optimal. But we may get a valuable expirience. > Rather than adding a lot of conditional code to the LLVM instrumentation phase We do this for hwasan for Android, and to some extent msan for Chromium. @eugenis maybe can share more info. > Based on previous discussions about this topic, our understanding is that > freezing the present ABI would impose an excessive burden on other sanitizer > developers and for unrelated platforms. I guess we just have no way to enforce that. A couple of buildbots with "stable clang" + "HEAD runtime" and "HEAD clang" + "stable runtime" which do some non-tivial build, e.g. clang bootstrap can enforce that. We can at list to enforce default set of flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
