dblaikie accepted this revision. dblaikie added a comment. I wouldn't mind a follow-up commit that creates a new/separate directory (llvm/{lib,include/llvm}/CodeGenTypes) but that's probably a lot of unnecessary churn too, so I can appreciate the argument against it - if folks reckon it's better this way, that's OK too. It can just get a bit confusing when the directory/naming doesn't match the layering, etc. Might make it more likely someone regresses these boundaries by introducing new dependencies that break the layering here.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148769/new/ https://reviews.llvm.org/D148769 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits