shafik added a comment.

In D148924#4318381 <https://reviews.llvm.org/D148924#4318381>, @massberg wrote:

> I have checked the paper P2002R1 and as far as I can tell it is fully 
> implemented when this patch has landed.

So I read the paper but since the paper does not have examples for each change 
nor does it have any links to DRs it is not obvious without spending some time 
to verify that we support each section. Changes like these really should come 
with examples in the paper to demonstrate behavior before and after.

I searched in the code and found that @rsmith labelled P2002R0 changes with 
comments and so a cursory look at those changes side by side with the paper 
seems to indicate that we probably covered most of the cases but I am not 100% 
sure. There is test coverage added with those changes as well but again 
relating each test to specific paper section is not trivial, at least for me.

The paper also uses the term constexpr compatible which has been replaced with 
constexpr suitable and not sure if that has any practical effect here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148924/new/

https://reviews.llvm.org/D148924

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to