[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:3164
     }
-
     return false;
----------------
Drop this change


================
Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:650
+    LLVM_DEBUG(
+        dbgs() << "Trying Zcmp table (16-bit Table Jump Instructions):\n");
+    Result =
----------------
This description is from Zcmt.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZc.td:235
+}
+} // DecoderNamespace = "RVZcmp", Predicates = [HasStdExtZcmp]...
+
----------------
This brace only closes `Predicates = [HasStdExtZcmp]`. The DecoderNamespace 
ended on line 189. It's only covering CM_MVA01S and CM_MVSA01.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132819/new/

https://reviews.llvm.org/D132819

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits