rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
LGTM, thanks! ================ Comment at: test/SemaCXX/constant-expression-cxx11.cpp:2091 @@ +2090,3 @@ + }; + static_assert(X::f() == c + d,""); +} ---------------- I would use `'c' + 'd'` here, just in case we get the same incorrect value evaluating one of these in both places. (That is, if `d` incorrectly evaluated to `0` both here and on line 2088, this assert would still pass.) https://reviews.llvm.org/D23493 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
