kadircet created this revision. kadircet added reviewers: hokein, PiotrZSL. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.
CheckName retrieived during construction is a reference to keys stored inside ClangTidyCheckFactories, which isn't guranteed to outlive the check. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150254 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h Index: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h =================================================================== --- clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h +++ clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h @@ -11,6 +11,7 @@ #include "../utils/RenamerClangTidyCheck.h" #include <optional> +#include <string> namespace clang::tidy { namespace readability { @@ -202,7 +203,7 @@ mutable llvm::StringMap<FileStyle> NamingStylesCache; FileStyle *MainFileStyle; ClangTidyContext *Context; - const StringRef CheckName; + const std::string CheckName; const bool GetConfigPerFile; const bool IgnoreFailedSplit; HungarianNotation HungarianNotation;
Index: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h =================================================================== --- clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h +++ clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h @@ -11,6 +11,7 @@ #include "../utils/RenamerClangTidyCheck.h" #include <optional> +#include <string> namespace clang::tidy { namespace readability { @@ -202,7 +203,7 @@ mutable llvm::StringMap<FileStyle> NamingStylesCache; FileStyle *MainFileStyle; ClangTidyContext *Context; - const StringRef CheckName; + const std::string CheckName; const bool GetConfigPerFile; const bool IgnoreFailedSplit; HungarianNotation HungarianNotation;
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits