MaskRay added a comment. In D148490#4334476 <https://reviews.llvm.org/D148490#4334476>, @shchenz wrote:
>> I am not sure you need 6 RUN lines to test this. Whether a target uses >> integrated assembler has an existing test file and you can reuse that. > > I don't have strong prefer which one we should use, a new file or reuse file. > Since you point out, I change to reuse a legacy one in same dir. Please > notice that there are some other targets that has their own assembler test > file, like mips-as.s, systemz-as.s, arm64-as.s. Thanks. It makes sense to check whether reusing a test file (possibly renaming it) makes sense. https://maskray.me/blog/2021-08-08-toolchain-testing "an existing test can be enhanced" Some existing tests can be improved. You may improve the testing without cargo culting:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
