Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land.
In D150450#4338065 <https://reviews.llvm.org/D150450#4338065>, @erichkeane wrote: > In D150450#4338034 <https://reviews.llvm.org/D150450#4338034>, @Mordante > wrote: > >> In D150450#4337952 <https://reviews.llvm.org/D150450#4337952>, @erichkeane >> wrote: >> >>> In D150450#4337858 <https://reviews.llvm.org/D150450#4337858>, @cor3ntin >>> wrote: >>> >>>> Similar PR here https://reviews.llvm.org/D149875 >>> >>> Ah! I'd not noticed that one (or maybe someone mentioned it?). If >>> @Mordante wants to take this over/change his to meet our RFC, I'm all for >>> it. >> >> I've mentioned it in >> https://discourse.llvm.org/t/rfc-lets-just-call-it-c-26-and-forget-about-the-c-2c-business-at-least-internally/70383/3 >> to avoid duplicated effort. >> >> It seems, as expected. the patches have a large overlap, but you added a bit >> more of the status page and I updated the clang-cl driver. >> >> I just updated my patch before I saw this update in the mail. > > Woops, looks like that was long enough ago I completely forgot about it :) > > Completely up to you if you want to just steal my stuff and we can go with > your review, or you want to just help me fill in anything I missed here. No problem. I think it's easier to land this patch instead of me stealing your work. I mainly care that Clang get C++2c support so I can prepare libc++ for C++2c. LGTM after `clang/test/Driver/cl-options.c` is fixed. ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6650 // TODO add c++23 when MSVC supports it. - .Case("c++latest", "-std=c++23") + .Case("c++latest", "-std=c++26") .Default(""); ---------------- The CI will fail in the test clang/test/Driver/cl-options.c see https://reviews.llvm.org/D149875#change-s8WC0AhDg4dT ================ Comment at: clang/test/Preprocessor/init.c:22 // RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=c++23 -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix CXX2B %s +// RUN: %clang_cc1 -x c++ -fgnuc-version=4.2.1 -std=c++2b -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix CXX2B %s // ---------------- I had noticed I missed this too, this landed earlier today D150063. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
