aaron.ballman accepted this revision.
aaron.ballman added a comment.

In D149997#4338897 <https://reviews.llvm.org/D149997#4338897>, @mstorsjo wrote:

> Updated to check for `defined(_WIN32) && !defined(__MINGW32__)`. It's a kinda 
> ugly way of checking for an MSVC-like environment specifically (when the MSVC 
> mode is the exception compared with the rest), but neither `_MSC_VER` or 
> `_MSC_EXTENSIONS` are defined by default in a `clang -cc1` invocation.

This seems like forward progress to me, so LG!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149997/new/

https://reviews.llvm.org/D149997

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to