kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.
LG. Please wait a day before submitting.
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:455-468
+ auto Buf = MemoryBuffer::getFile(HostFilePath);
+ if (auto Err = Buf.getError())
+ report_fatal_error(("error opening host file from host file path inside of
"
+ "OpenMPIRBuilder: " +
+ Err.message())
+ .c_str());
+
----------------
Nit: Might be good to spell the types and use braces for multi-line code inside
`if`.
================
Comment at: mlir/include/mlir/Target/LLVMIR/ModuleTranslation.h:18
#include "mlir/Dialect/LLVMIR/LLVMInterfaces.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
#include "mlir/IR/Operation.h"
----------------
Nit: Is this required here? Can it be in the CPP File?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148370/new/
https://reviews.llvm.org/D148370
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
