jansvoboda11 added inline comments.
================
Comment at: clang/test/ClangScanDeps/modules-private-framework-submodule.c:43
// CHECK-NEXT: "context-hash": "{{.*}}",
-// CHECK-NEXT: "module-name": "FW2_Private"
+// CHECK-NEXT: "module-name": "FW2"
// CHECK-NEXT: }
----------------
benlangmuir wrote:
> Does this lose any test coverage for the FW2_Private case?
This still tests the same general code path, just a more specific case of it. I
can keep this test as is and create new one specifically to test the "explicit
submodule" case if that makes more sense to you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150479/new/
https://reviews.llvm.org/D150479
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
