barannikov88 added inline comments.

================
Comment at: clang/test/OpenMP/task_firstprivate_codegen.cpp:264
 
-// CHECK: alloca i32*,
-// CHECK: [[PRIV_T_VAR_ADDR:%.+]] = alloca i32*,
-// CHECK: [[PRIV_S_ARR_ADDR:%.+]] = alloca [2 x [[S_DOUBLE_TY]]]*,
-// CHECK: [[PRIV_VEC_ADDR:%.+]] = alloca [2 x i32]*,
-// CHECK: [[PRIV_SIVAR_ADDR:%.+]] = alloca i32*,
-// CHECK: [[PRIV_VAR_ADDR:%.+]] = alloca [[S_DOUBLE_TY]]*,
-// CHECK: store void (i8*, ...)* bitcast (void ([[PRIVATES_MAIN_TY]]*, i32**, 
[2 x [[S_DOUBLE_TY]]]**, [2 x i32]**, i32**, [[S_DOUBLE_TY]]**)* 
[[PRIVATES_MAP_FN]] to void (i8*, ...)*), void (i8*, ...)** [[MAP_FN_ADDR:%.+]],
-// CHECK: [[MAP_FN:%.+]] = load void (i8*, ...)*, void (i8*, ...)** 
[[MAP_FN_ADDR]],
+// CHECK: %__context
+// CHECK: [[PRIV_T_VAR_ADDR:%.+]] = alloca ptr,
----------------
barannikov88 wrote:
> There is a bunch of `alloca ptr,` before the next CHECK lines. The exect 
> number differs between tests.
> I couldn't find a better solution than to rely on the name of one of them.
> 
E.g.:
```
  %.part_id..addr.i = alloca ptr, align 8
  %.privates..addr.i = alloca ptr, align 8
  %.copy_fn..addr.i = alloca ptr, align 8
  %.task_t..addr.i = alloca ptr, align 8
  %__context.addr.i = alloca ptr, align 8
  %.firstpriv.ptr.addr.i = alloca ptr, align 8
  %.firstpriv.ptr.addr1.i = alloca ptr, align 8
  %.firstpriv.ptr.addr2.i = alloca ptr, align 8
  %ref.tmp.i = alloca %class.anon.0, align 8
```
and we need to match the `firstpriv` ones. It so happens that in all tests 
`%__context` precedes the interesting lines.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150608/new/

https://reviews.llvm.org/D150608

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to