craig.topper added inline comments.

================
Comment at: clang/lib/CodeGen/CGCall.cpp:3070
+
+          llvm::Value *LoadedStructValue = CreateCoercedLoad(Ptr, STy, *this);
+
----------------
eopXD wrote:
> craig.topper wrote:
> > What are we loading here?
> > 
> > Is there a test for this code?
> You are right, should be a poison here.
> 
> Test case 
> `clang/test/CodeGen/RISCV/rvv-intrinsics-handcrafted/rvv-tuple-type-0.c` and 
> `clang/test/CodeGen/RISCV/rvv-intrinsics-handcrafted/rvv-tuple-type-1.c` 
> covers the code here.
Thanks. I had tried to scan the tests to see if I could find the extra load, 
but I guess I missed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146873/new/

https://reviews.llvm.org/D146873

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to