aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed.
The changes are missing Sema tests for diagnosing incorrect appertainment, arguments, etc. It would also be good to have a CodeGen test showing the behavior works on an ObjC method and a C++ lambda. This should also come with a release note in clang/docs/ReleaseNotes.rst (there's a section specifically for attributes). ================ Comment at: clang/include/clang/Basic/AttrDocs.td:587-588 + +Suppresses outlining from a function. Functions with this attribute will not +be considered for outlining. + ---------------- I'd appreciate a bit more explanation/link to what outlining *is*. These docs don't really help a user understand the feature (the example is especially confusing because it shows typical C code with no explanation as to what happens with the attribute). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150740/new/ https://reviews.llvm.org/D150740 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
