This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30c57e275e5a: [Fuchsia] Correctly pass lists from STAGE2_ vars (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150799/new/ https://reviews.llvm.org/D150799 Files: clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake =================================================================== --- clang/cmake/caches/Fuchsia.cmake +++ clang/cmake/caches/Fuchsia.cmake @@ -182,7 +182,8 @@ foreach(variableName ${variableNames}) if(variableName MATCHES "^STAGE2_") string(REPLACE "STAGE2_" "" new_name ${variableName}) - list(APPEND EXTRA_ARGS "-D${new_name}=${${variableName}}") + string(REPLACE ";" "|" value "${${variableName}}") + list(APPEND EXTRA_ARGS "-D${new_name}=${value}") endif() endforeach()
Index: clang/cmake/caches/Fuchsia.cmake =================================================================== --- clang/cmake/caches/Fuchsia.cmake +++ clang/cmake/caches/Fuchsia.cmake @@ -182,7 +182,8 @@ foreach(variableName ${variableNames}) if(variableName MATCHES "^STAGE2_") string(REPLACE "STAGE2_" "" new_name ${variableName}) - list(APPEND EXTRA_ARGS "-D${new_name}=${${variableName}}") + string(REPLACE ";" "|" value "${${variableName}}") + list(APPEND EXTRA_ARGS "-D${new_name}=${value}") endif() endforeach()
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits