sfantao added a comment. Hi Jonas,
Thanks again for the review! ================ Comment at: test/CMakeLists.txt:27-33 @@ -26,8 +26,9 @@ list(APPEND CLANG_TEST_DEPS clang clang-headers clang-format c-index-test diagtool clang-tblgen + clang-offload-bundler ) ---------------- Hahnfeld wrote: > Most users will get it anyway because it is built for the `install` target > and I think the build system should do its best to build and install all > needed dependencies. > > I think this currently only fails when using `make clang` and then trying to > invoke the compiler from the build directory. I agree that this should be > quite rare but that could be fixed by `add_dependencies(clang > clang-offload-bundler)` which has worked for me. However I now don't have a > really strong opinion here because it works with the `install` target. Ok, I added the line `add_dependencies(clang clang-offload-bundler) ` as you suggest. I was worried that referring to clang libs would cause a circular dependency, but it seems to work just fine. https://reviews.llvm.org/D13909 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
