cor3ntin added a comment. Thanks, It's great to have the complete feature in on PR
================ Comment at: clang/include/clang/Sema/Sema.h:9661 + struct BuildingDeductionGuides {}; + /// Note that we are instantiating an exception specification + /// of a function template. ---------------- Is that comment correct? ================ Comment at: clang/lib/Sema/SemaDecl.cpp:12637 - if (DirectInit) { - if (auto *PL = dyn_cast_or_null<ParenListExpr>(Init)) - DeduceInits = PL->exprs(); - } + auto *PL = dyn_cast_or_null<ParenListExpr>(Init); + if (DirectInit && PL) ---------------- ================ Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1059-1062 + case CodeSynthesisContext::BuildingDeductionGuides: + assert( + false && + "failed building deduction guides, add meaningful diagnostics here"); ---------------- This seems unfinished Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits