gribozavr accepted this revision.
gribozavr added a comment.
This revision is now accepted and ready to land.

LGTM with two more tests.


================
Comment at: test/Sema/warn-documentation.cpp:433
@@ +432,3 @@
+template<typename T>
+using test_function_like_usingA = foo::function_wrapper<int (T aaa, int ccc)>;
+
----------------
For consistency with the rest of the file, could you use '11' instead of 'A'?

Could you also add these two tests:

```
/// <please-add-some-comment>
template<typename T>
using test_function_like_using10 = int (*)(T aaa, int ccc);

/// <please-add-some-comment>
template<typename T>
using test_function_like_using12 = foo::function_wrapper<int (T aaa, int ccc)> 
*;
```


https://reviews.llvm.org/D23860



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to