MaskRay accepted this revision.
MaskRay added a comment.

LGTM.



================
Comment at: compiler-rt/docs/ASanABI.rst:15
+
+    ...
+    void __asan_load1(uptr p) { __asan_abi_loadn(p, 1, true); }
----------------
Delete `...`. Sample content implies that this is a code fragment and does not 
contain everything, so `...` is redundant.


================
Comment at: compiler-rt/docs/ASanABI.rst:22
+
+The shim library is only used when -fsanitize-stable-abi is specified in the 
Clang driver and the emitted instrumentation favors runtime calls over inline 
expansion.
+
----------------
Quote all compiler driver options with double backsticks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143675/new/

https://reviews.llvm.org/D143675

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to