Author: Timm Bäder Date: 2023-05-31T10:21:24+02:00 New Revision: b5c7892d54f8d415e3e0198e067886c825f26e0c
URL: https://github.com/llvm/llvm-project/commit/b5c7892d54f8d415e3e0198e067886c825f26e0c DIFF: https://github.com/llvm/llvm-project/commit/b5c7892d54f8d415e3e0198e067886c825f26e0c.diff LOG: [clang][Diagnostics][NFC] Move Buf{Start,End} out of the loop They don't change inside the loop. Added: Modified: clang/lib/Frontend/TextDiagnostic.cpp Removed: ################################################################################ diff --git a/clang/lib/Frontend/TextDiagnostic.cpp b/clang/lib/Frontend/TextDiagnostic.cpp index f817ab7d3613..11ae2667dfa8 100644 --- a/clang/lib/Frontend/TextDiagnostic.cpp +++ b/clang/lib/Frontend/TextDiagnostic.cpp @@ -1134,6 +1134,8 @@ void TextDiagnostic::emitSnippetAndCaret( StringRef BufData = Loc.getBufferData(&Invalid); if (Invalid) return; + const char *BufStart = BufData.data(); + const char *BufEnd = BufStart + BufData.size(); unsigned CaretLineNo = Loc.getLineNumber(); unsigned CaretColNo = Loc.getColumnNumber(); @@ -1167,9 +1169,6 @@ void TextDiagnostic::emitSnippetAndCaret( for (unsigned LineNo = Lines.first; LineNo != Lines.second + 1; ++LineNo, ++DisplayLineNo) { - const char *BufStart = BufData.data(); - const char *BufEnd = BufStart + BufData.size(); - // Rewind from the current position to the start of the line. const char *LineStart = BufStart + _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits