MaskRay added inline comments.

================
Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:195
+    if (!hasV6MOps())
+      llvm_unreachable("Cannot generate execute-only code for this target");
   }
----------------
If this code path is actually reachable, a proper error reporting will be 
better. At the least `report_fatal_error` can be used. Don't use 
`llvm_unreachable` for known-reachable code paths.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149444/new/

https://reviews.llvm.org/D149444

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to