erichkeane added a comment. Couple of CFE comments, otherwise LGTM.
================ Comment at: clang/docs/ReleaseNotes.rst:559 ^^^^^^^^^^^^^^^^^^^ +- Added ``attribute((wasm_async))`` to indicate that a function should be used with + JavaScript Promise Integration (JSPI). ---------------- We require underscores to spell it in code, so I figure we should do it here too. ================ Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7638 + D->addAttr(::new (S.Context) WebAssemblyAsyncAttr(S.Context, AL)); + D->addAttr(UsedAttr::CreateImplicit(S.Context)); +} ---------------- We should probably document that this forces the function to be emitted as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
