tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
I'd change the patch title: - `[NVPTX]` -> `[cuda, NVPTX]` as these are clang changes, not NVPTX back-end. - `overloads ` -> `builtins` ================ Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:862 BUILTIN(__nvvm_ldg_c, "ccC*", "") +BUILTIN(__nvvm_ldg_sc, "ScScC*", "") BUILTIN(__nvvm_ldg_s, "ssC*", "") ---------------- One thing that bugs me is that ldg should technically be a `TARGET_BUILTIN(..., AND(PTX31,SM_32))`. Oh, well, that train is gone now that pre-sm3x GPUs are no longer supported by NVIDIA anyways. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151876/new/ https://reviews.llvm.org/D151876 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
