charmitro added inline comments.
================ Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: ---------------- tbaeder wrote: > This checks the same thing in both cases, but in the `NORMAL` case, it should > //not// use the absolute path, shouldn't it? You're correct. I was constantly testing it from the same path. Since the relative path is going to be different depending on where you running from, would it be wise to accept a regular expression of any string in the `NORMAL` case? For example, ``` NORMAL: In file included from {{.*}}: ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits