craig.topper added inline comments.
================ Comment at: clang/include/clang/Basic/riscv_vector.td:1533 + + if (NoPassthru) // Push poison into passthru + Operands.append(NF, llvm::PoisonValue::get(ElementVectorType)); ---------------- `if` should use curly braces if the `else` uses curly braces. ================ Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:895 + case 2: + return VectorTypeModifier::Tuple2; + case 3: ---------------- Can we guarantee Tuple2-8 are contiguous? Then we can do `return (NF - 2) + VectorTypeModifier::Tuple2` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152071/new/ https://reviews.llvm.org/D152071 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
