sdesmalen added inline comments.

================
Comment at: clang/lib/Sema/SemaExpr.cpp:11119
   if ((OperationKind == ACK_Arithmetic) &&
       ((LHSBuiltinTy && LHSBuiltinTy->isSVEBool()) ||
        (RHSBuiltinTy && RHSBuiltinTy->isSVEBool()))) {
----------------
This doesn't seem like a non-functional change. Here it checks that 
LHSBuiltinTy is not nullptr before using it, which suggests that it is valid 
for LHSType/RHSType not to be a builtin type. There is also nothing else 
guarding that the types are all VLSTBuiltinTypes. Do none of the tests fail?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152197/new/

https://reviews.llvm.org/D152197

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D152197: [NFC][CL... Sander de Smalen via Phabricator via cfe-commits

Reply via email to