isuckatcs added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306 + + if (From->isMemberPointerType() || To->isMemberPointerType()) return false; ---------------- isuckatcs wrote: > Please cover this line with both positive and negative test cases. > > Also upon looking up both [[ > https://www.open-std.org/jtc1/sc22/wg21/docs/standards | N4849 ]] (C++ 20 > draft) and [[ https://github.com/cplusplus/draft/releases | N4917]] (C++ 23 > draft), they both say for qualification conversion that > > > > each P_i is ... pointer to member of class C_i of type, ... > > Why are we not allowing them if the standard is at least C++ 20? Please resolve this thread. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits