alexander-shaposhnikov added inline comments.
================ Comment at: clang/lib/Sema/SemaType.cpp:8168 + IsTargetCUDAAndHostARM = + !AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM(); + } ---------------- tra wrote: > Should it be `AuxTI && (AuxTI->getTriple().isAArch64() || > AuxTI->getTriple().isARM();)` ? > > I don't think we want IsTargetCUDAAndHostARM to be set to true if there's no > auxTargetInfo (e.g. during any C++ compilation, regardless of the target). we get here only if S.getLangOpts().CUDAIsDevice is true, so not for an arbitrary c++ compilation, iirc AuxTI was null for some tests, but I'm happy to double check, AuxTI && ... looks better to me too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152403/new/ https://reviews.llvm.org/D152403 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
