I'll be unavailable the next 2 weeks, feel free to do it if you want! On Fri, Jun 9, 2023, 21:10 Tom Honermann via Phabricator < revi...@reviews.llvm.org> wrote:
> tahonermann added a comment. > > @cor3ntin, sorry for failing to keep up with reviews; I know this has > already been committed. I did spot a couple of typos should you feel > inclined to address them. > > > > ================ > Comment at: clang/lib/Lex/Lexer.cpp:2695 > + // diagnostic only once per entire ill-formed subsequence to avoid > + // emiting to many diagnostics (see > http://unicode.org/review/pr-121.html). > + bool UnicodeDecodingAlreadyDiagnosed = false; > ---------------- > > > > ================ > Comment at: clang/lib/Lex/Lexer.cpp:2398 > + // diagnostic only once per entire ill-formed subsequence to avoid > + // emiting to many diagnostics (see > http://unicode.org/review/pr-121.html). > + bool UnicodeDecodingAlreadyDiagnosed = false; > ---------------- > > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D128059/new/ > > https://reviews.llvm.org/D128059 > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
