MaskRay added inline comments.
================ Comment at: clang/test/Driver/clang-translation.c:132 +// ARMv7_THREAD_POINTER-HARD: "-target-feature" "+read-tp-tpidruro" + +// RUN: %clang -target armv7-linux -mtp=tpidruro -### -S %s 2>&1 | \ ---------------- `clang-translation.c`'s job is shifting, but I think it is mainly for testing common options. For Arm-specific testing, I think using a `arm-*.c` file will be more appropriate. Ideally we can find an existing file where new RUN lines seem appropriate, as a fallback we can introduce a new test file:) Also, use `--target=` for new tests. `-target ` has been deprecated (without a warning) since Clang 3.x era. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152433/new/ https://reviews.llvm.org/D152433 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
