Destroyerrrocket added inline comments.
================
Comment at: clang-tools-extra/clangd/ModulesManager.cpp:413-414
+ else
+ WaitingCallables[Filename.str()].push_back(
+ {std::move(ReadyCallback), std::move(ReadyCallback)});
+}
----------------
ChuanqiXu wrote:
> Destroyerrrocket wrote:
> > This is a bug; The second move is invalid. You could make a copy
> Done. Thanks for looking this. I changed it with a new signature for the
> callbacks with a bool argument.
No problem! I'd love to help :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153114/new/
https://reviews.llvm.org/D153114
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
