shafik added inline comments.
================ Comment at: clang/lib/Sema/SemaExpr.cpp:18177 getASTContext()), /*IsImmediateInvocation*/ true); if (Cached.hasValue()) ---------------- Drive by nit clean-up while we are here. ================ Comment at: clang/test/SemaCXX/consteval-cleanup.cpp:19 + // CHECK: foo + // CHECK: ExprWithCleanups + // CHECK-NEXT: BinaryOperator ---------------- I am not too sure on this but perhaps showing `P : P` and `A : A` in the checks would be helpful Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153294/new/ https://reviews.llvm.org/D153294 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits