simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land.
LGTM. One of the thoughts I mentioned offline before this patch was written was that maybe the error would need to be conditional, via a directive inside `multilib.yaml` itself – perhaps some users want to fall off the end of the multilib list without error and continue using the default sysroot, whereas others want to diagnose "sorry, no library at all is available to support your flags"? But I suppose there won't be a large user base who were already using this particular YAML technique in the former mode, or at all, because it's so new. And if necessary one could reorganise to put `multilib.yaml` in its own directory, and add a final catch-all entry pointing at the fallback sysroot. So it should be OK to have the error unconditional. ================ Comment at: clang/test/Driver/baremetal-multilib.yaml:88-90 +- Dir: arm-none-eabi/arm/v4t + Flags: [--target=armv4t-none-unknown-eabi] + ---------------- I'm not sure what the purpose of this addition is. It doesn't seem to be listed in the expected error messages (but it's presumably being printed anyway, and skipped over because the checks don't say `-NEXT`?). Did it sneak in here from another commit, perhaps? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153292/new/ https://reviews.llvm.org/D153292 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
