cjdb added a comment.
I think this will be a good addition because it underscores the salient part of
why the function isn't viable.
Would it be possible for patches like this to have both examples of before and
after this patch in their commit message please? That'll help expose why
patches like this are desirable. Happy to LGTM afterwards.
================
Comment at: clang/test/Misc/diag-func-call-ranges.cpp:13
+void arity_mismatch() {
+ (void)func(2, 4);
+}
----------------
Why are you casting to void?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153267/new/
https://reviews.llvm.org/D153267
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
