efriedma added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6864
+ CmdArgs.push_back("-fexec-charset");
+ CmdArgs.push_back(Args.MakeArgString(Triple.getSystemCharset()));
if (Arg *execCharset = Args.getLastArg(options::OPT_fexec_charset_EQ)) {
----------------
The default should be in the "else"? It's confusing to pass two -fexec-charset
arguments, even if it works.
================
Comment at: clang/lib/Lex/LiteralSupport.cpp:2145
+ memcpy(Cp, CpConv.data(), ResultLength);
+ ResultPtr = Cp + CpConv.size();
+ }
----------------
Can the code be refactored to put this repeated sequence into a helper function?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153419/new/
https://reviews.llvm.org/D153419
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
