MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed.
================ Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:732 +def warn_drv_loongarch_conflicting_mabi : Warning< + "the -mabi setting '%0' conflicts with that implied by -m*-float (%1); using %1">, + InGroup<OptionIgnored>; ---------------- This is not called `setting`. Use `value` It seems that `ignoring -mabi value '%0' as it conflicts ...` is more conventional. ================ Comment at: clang/test/Driver/loongarch-msingle-float.c:10 -// WARN: warning: argument unused during compilation: '-mfpu=0' -// WARN: warning: argument unused during compilation: '-mabi=lp64s' +// NOWARN-NOT: warning: argument unused during compilation: '-mfpu=32' +// NOWARN-NOT: warning: argument unused during compilation: '-mabi=lp64f' ---------------- Just use `NOWARN-NOT: warning:` to assert that there is no diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153707/new/ https://reviews.llvm.org/D153707 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
