aaron.ballman added a comment.
Changes generally LGTM, but I'll leave it to @tahonermann to do the final
sign-off given this is related to text.
================
Comment at: clang/test/Preprocessor/ucn-allowed-chars.c:86
+#define AAA\u0024 // expected-error{{character '$' cannot be specified by a
universal character name}} \
+ // expected-warning{{whitespace}}
+#define AAB\u0040 // expected-error{{character '@' cannot be specified by a
universal character name}} \
----------------
cor3ntin wrote:
> aaron.ballman wrote:
> > I'd like more context for this diagnostic message because I have no idea
> > what it's trying to warn.
> The warning is either
> ```
> whitespace required after macro name
> ISO C99 requires whitespace after the macro name
> ```
> in C++ and C respectively.
>
> Given it's not salient, I did that. Let me know if you want me to add a
> different verify tag
I'd say leave it as-is for now, but we really should unify these diagnostics
(then we can at least use something more descriptive like `whitespace required
after macro name`, leaving off the ISO C bits)
================
Comment at: clang/test/Preprocessor/ucn-pp-identifier.c:160
// expected-warning@-1 {{incomplete}}\
-// expected-error@-1 {{expected ';' after top level declarator}}
+// expected-error@-1 {{expected}}
#endif
----------------
This is another spot where we really should be spelling out the diagnostic.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153621/new/
https://reviews.llvm.org/D153621
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
