ahatanak added inline comments.

================
Comment at: lib/Sema/SemaDecl.cpp:3377-3378
@@ -3376,4 +3376,4 @@
 
           if (!Context.hasSameType(NewArray, PrevVDTy))
             return diagnoseVarDeclTypeMismatch(*this, New, PrevVD);
         }
----------------
rsmith wrote:
> If you do use `isDependentSizedArrayType()`, you'll need to change this to 
> check the bounds of the array types rather than the type.
It seems to me that you don't want to do the check when either the array bound 
or the element type is dependent. Which case would we miss if isDependentType 
is used here instead of isDependentSizedArrayType? Could you show an example?


https://reviews.llvm.org/D24110



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to