hokein added inline comments.
================ Comment at: llvm/unittests/Support/raw_ostream_test.cpp:525 + ASSERT_TRUE(Perms) << "should be able to get permissions"; + // Verify that writeToOutput doesn't set exe bit. + EXPECT_EQ(Perms.get(), llvm::sys::fs::all_read | llvm::sys::fs::all_write); ---------------- avl wrote: > nit: comment looks a bit inconsistent as we check for read&write bits. refined the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153652/new/ https://reviews.llvm.org/D153652 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits