rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
Wow, what an amazing bug :) ================ Comment at: clang/lib/CodeGen/CGDecl.cpp:2459 + if (!isa<llvm::GlobalValue>(Arg.getAnyValue())) + Arg.getAnyValue()->setName(D.getName()); ---------------- Is it feasible to only set the name if the value doesn't already have a name, or do we give values bad names often enough that it's better to overwrite an existing name here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154270/new/ https://reviews.llvm.org/D154270 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
