aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM, thank you! ================ Comment at: clang/docs/ReleaseNotes.rst:552 (`#63503 <https://github.com/llvm/llvm-project/issues/63503>`_) +- Fixed parsing of elaborated type specifier inside of a new expression + (`#34341 <https://github.com/llvm/llvm-project/issues/34341>`_) ---------------- ================ Comment at: clang/include/clang/Parse/Parser.h:2221 + DSC_association, // A _Generic selection expression's type association + DSC_new // C++ new operator }; ---------------- Fznamznon wrote: > aaron.ballman wrote: > > Adding the comma so the next person doesn't have to, and realigning to the > > usual indentation > Added comma, but the indentation is what clang-format gave me. I'm afraid I > won't pass the pre-commit with different . Ah, we don't care if pre-commit CI fails because of clang-format due to following the surrounding formatting style. That said, this formatting is already inconsistent (I hadn't noticed the first three are at a different indentation level as well), so this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153857/new/ https://reviews.llvm.org/D153857 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
