hokein added inline comments.
================
Comment at: lldb/tools/lldb-server/lldb-platform.cpp:112
return Status("Failed to atomically write file %s",
file_spec.GetPath().c_str());
return status;
----------------
avl wrote:
> probably, it would be better to add error text here?
>
> ```
> return Status("Failed to atomically write file %s: %s",
> file_spec.GetPath().c_str(),
> toString(std::move(Err)).c_str());
> ```
good idea.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154329/new/
https://reviews.llvm.org/D154329
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
