george.burgess.iv added a subscriber: george.burgess.iv. george.burgess.iv added a comment.
Just a drive-by nit. Thanks for the patch! ================ Comment at: lib/Sema/SemaOverload.cpp:12996 @@ +12995,3 @@ + // selection expression. + std::vector<Expr *> AssocExprs(GSE->getAssocExprs().vec()); + unsigned ResultIdx = GSE->getResultIndex(); ---------------- Is there a reason this isn't a `SmallVector` instead? https://reviews.llvm.org/D24152 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
