phosek added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Serenity.h:38
+
+class LLVM_LIBRARY_VISIBILITY Serenity : public ToolChain {
+public:
----------------
Have you considered inheriting from `Generic_GCC` to allow more code reuse?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154396/new/

https://reviews.llvm.org/D154396

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to