[PATCH] D154635: [7/8][RISCV] Add rounding mode control variant for conversion intrinsics between floating-point and integer

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:6769
+let hasSideEffects = 0 in {
+defm PseudoVFWCVT_F_XU     : VPseudoVWCVTF_V_RM;
+defm PseudoVFWCVT_F_X      : VPseudoVWCVTF_V_RM;
----------------
These don't need rounding mode. As the spec ssys "A double-width IEEE 
floating-point value can always represent a single-width integer exactly." Not 
sure why they had an FRM use before.

I'm also very unsure why PseudoVFWCVT_RM_F_XU and PseudoVFWCVT_RM_F_X exist.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:6775
 
-defm PseudoVFWCVT_F_F      : VPseudoVWCVTD_V;
+defm PseudoVFWCVT_F_F      : VPseudoVWCVTD_V_RM;
 } // mayRaiseFPException = true
----------------
VFWCVT_F_F doesn't need rounding mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154635/new/

https://reviews.llvm.org/D154635

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits